Anyone with basic knowledge of SQL injection could login to this site and add anyone they wanted to KCM and CASS, allowing themselves to both skip security screening and then access the cockpits of commercial airliners.

  • @polaris64
    link
    English
    173 months ago

    …We did not want to contact FlyCASS first as it appeared to be operated only by one person and we did not want to alarm them. On April 23rd, we were able to disclose the issue to the Department of Homeland Security, who acknowledged the issue and confirmed that they “are taking this very seriously”.

    I think the owner of FlyCASS was sufficiently alarmed!

        • @0x0@programming.devOP
          link
          fedilink
          English
          13 months ago

          He does that a lot, although he tends to be more verbose on the topic when he does. Then again, there’s not much to this story (the details, not the implications).

  • @cron@feddit.org
    link
    fedilink
    English
    63 months ago

    We ended up finding several more serious issues but began the disclosure process immediately after finding the first issue.

    How many vulnerabilities can there be in such a safety-critical application?

    • @0x0@programming.devOP
      link
      fedilink
      English
      8
      edit-2
      3 months ago

      No for-profit will bother with security unless forced to, as it’s seen as an expense and shareholders don’t like that.

      Edit: also:

      We had difficulty identifying the right disclosure contact for this issue. We did not want to contact FlyCASS first as it appeared to be operated only by one person and we did not want to alarm them.

      Emphasis mine.

      • @Telorand@reddthat.com
        link
        fedilink
        English
        5
        edit-2
        3 months ago

        Bruh, it’s 2024, and banks still don’t have app-based or hardware-based TOTP.

        I get that upgrading can be hard, but when you’re safeguarding people’s lives or money (and also PII), I don’t understand how it’s not a legal mandate that you have to meet certain basic security thresholds.

        Edit: typo

      • Trailblazing Braille Taser
        link
        fedilink
        English
        13 months ago

        The beautiful thing about string injection vulnerabilities is that they will never ever stop happening. It’s just too easy to sprintf untrusted input.

          • Trailblazing Braille Taser
            link
            fedilink
            English
            33 months ago

            You know, the reason this happens is that you can ask your database to execute a string type, but languages usually don’t distinguish between a static string and a dynamically constructed string.

            Not to proselytize, but this is a place where rust’s lifetime annotations can shine. The DB interface should take a &'static str( and a variable number of parameters to insert) so it can be certain that no untrusted user input has already been injected into the query string. Assuming all static data is trusted, the sql injection vulnerabilities just went poof.

            Sadly, it looks like rusqlite’s execute() takes a non-static str. I wonder why.