Anthony LavadoM to Jellyfin: The Free Software Media System@lemmy.mlEnglish • 9 months agoA Call for Developersjellyfin.orgexternal-linkmessage-square59fedilinkarrow-up1531arrow-down18cross-posted to: selfhosted@lemmit.onlinemain@selfhosted.forum
arrow-up1523arrow-down1external-linkA Call for Developersjellyfin.orgAnthony LavadoM to Jellyfin: The Free Software Media System@lemmy.mlEnglish • 9 months agomessage-square59fedilinkcross-posted to: selfhosted@lemmit.onlinemain@selfhosted.forum
minus-square@gardner@lemmy.nzlinkfedilinkEnglish32•edit-29 months agoI submitted a pull request that was shut down and the only feedback was “I don’t think this is the way we’d do it.” I know managing community contributions is a big task but if you want people to volunteer, a baseline amount of effort should be made to enable it. It’s also helpful to have automated tests to increase confidence that a change won’t break existing features.
minus-squareredfellowlinkfedilinkEnglish8•9 months agoThere was a baseline effort there. Your PR wasn’t a proper fix, but more of a hack which also isn’t in line with how a proper UI would display things.
minus-square@lud@lemm.eelinkfedilinkEnglish15•9 months agoThey are probably talking about this one: https://github.com/jellyfin/jellyfin-web/pull/3522
I submitted a pull request that was shut down and the only feedback was “I don’t think this is the way we’d do it.”
I know managing community contributions is a big task but if you want people to volunteer, a baseline amount of effort should be made to enable it.
It’s also helpful to have automated tests to increase confidence that a change won’t break existing features.
There was a baseline effort there. Your PR wasn’t a proper fix, but more of a hack which also isn’t in line with how a proper UI would display things.
Link?
They are probably talking about this one: https://github.com/jellyfin/jellyfin-web/pull/3522